[prev] [thread] [next] [lurker] [Date index for 2003/11/24]
On Mon, 24 Nov 2003, Shlomi Fish wrote: > > Notice that I corrected it. Now we assign $msg the exception string, but don't > do anything with it. Then we pass a generic MESSAGE string (that does not > tell the user what the problem is) to the template. Notice my correction. A > better one may be including the generic message followed by the particular > error. > > I'm not sending a patch yet, because I noticed it would break our test > scripts. (which can arguably be broken as well). What should we do? > Ok, the reason I did not want to send the real error message is because if that comes from the database (or maybe in other cases, i don't remember) it will contain physical path and maybe other info that might be sensitive. So I decided to postpone this. I thought of adding a number to each one of our error codes that we send, eg. prepend with "YAPCOM_ERROR #37 - " and then at the web interface level we will know if this is from us or from beneath us. Then we can also have a separate file in the templates directory that will translate ERROR #37 to some string that the template people can maintain. Some research of how other do this might needed here to see other options. Gabor
Generated at 21:06 on 24 Nov 2003 by mariachi 0.51